Project

General

Profile

Bug #8286

chxge: misleading-indentation

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2017-05-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error from gcc 6:

../../common/io/chxge/sge.c: In function 't1_espi_workaround':
../../common/io/chxge/sge.c:240:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if (sge->pskb)
    ^~
../../common/io/chxge/sge.c:243:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
     if (!rv)
     ^~
cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 3 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit f172c8ab1c246e78ba62a5aae1364ffcefe84862

commit  f172c8ab1c246e78ba62a5aae1364ffcefe84862
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-05T14:03:25.000Z

    8286 chxge: misleading-indentation
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF