Project

General

Profile

Bug #8290

libwanboot: misleading-indentation

Added by Toomas Soome about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2017-05-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error from gcc 6:

../../../common/net/wanboot/boot_http.c: In function 'http_srv_connect':
../../../common/net/wanboot/boot_http.c:728:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
   if (ctx != NULL)
   ^~
../../../common/net/wanboot/boot_http.c:730:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
    libbootlog(BOOTLOG_CRIT,
    ^~~~~~~~~~
cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 3 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit faaed6b6ad0f1ddac09711eea44b4bedd00bf2ce

commit  faaed6b6ad0f1ddac09711eea44b4bedd00bf2ce
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-02T17:49:04.000Z

    8290 libwanboot: misleading-indentation
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF