Project

General

Profile

Actions

Bug #8292

closed

rdc: misleading-indentation

Added by Toomas Soome over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2017-05-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Build error from gcc 6:

../../common/avs/ns/rdc/rdc_diskq.c: In function 'rdc_diskq_buf2queue':
../../common/avs/ns/rdc/rdc_diskq.c:1868:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if ((netq->nitems == 1) &&
    ^~
../../common/avs/ns/rdc/rdc_diskq.c:1871:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
     *abuf = NULL;
     ^
cc1: all warnings being treated as errors
Actions #1

Updated by Electric Monk over 6 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit fbab0d0f679993544c054684742e56ef33f4f678

commit  fbab0d0f679993544c054684742e56ef33f4f678
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-02T17:49:30.000Z

    8292 rdc: misleading-indentation
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF