Project

General

Profile

Actions

Bug #8320

closed

regcmp: misleading-indentation

Added by Toomas Soome about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2017-06-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error from gcc 6:

regcmp.c: In function 'main':
regcmp.c:112:4: error: this 'while' clause does not guard... [-Werror=misleading-indentation]
    while (((*name++ = c = getc(iobuf)) != ' ') &&
    ^~~~~
regcmp.c:114:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'while'
     *--name = '\0';
     ^
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 5 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 15a0c3a7ba78a992f7bad7c25b74c4a6b91b7ff4

commit  15a0c3a7ba78a992f7bad7c25b74c4a6b91b7ff4
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-11T16:31:06.000Z

    8320 regcmp: misleading-indentation
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions

Also available in: Atom PDF