Project

General

Profile

Actions

Bug #8326

closed

logger: misleading-indentation

Added by Toomas Soome about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2017-06-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error from gcc 6:

logger.c: In function 'main':
logger.c:145:2: error: this 'while' clause does not guard... [-Werror=misleading-indentation]
  while ((opt = getopt(argc, argv, "it:p:f:")) != EOF)
  ^~~~~
logger.c:177:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'while'
   argc -= optind;
   ^~~~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 311c88c1ed31408e0998a9aabb8e7d0d12ef83ad

commit  311c88c1ed31408e0998a9aabb8e7d0d12ef83ad
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-12T10:55:48.000Z

    8326 logger: misleading-indentation
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Actions

Also available in: Atom PDF