Project

General

Profile

Actions

Bug #8333

closed

idmap: misleading-indentation

Added by Toomas Soome about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2017-06-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error from gcc 6:

namemaps.c: In function 'idmap_set_namemap':
namemaps.c:906:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if (fullname == NULL)
    ^~
namemaps.c:908:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
     goto cleanup;
     ^~~~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3ad44b67f5f834e6fb4458edfb33a794a6576451

commit  3ad44b67f5f834e6fb4458edfb33a794a6576451
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-10T16:17:18.000Z

    8333 idmap: misleading-indentation
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF