Project

General

Profile

Actions

Bug #8340

closed

datadm: self-comparison always evaluates to false

Added by Toomas Soome about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2017-06-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build error from gcc 6:

datadm.c:713:23: error: self-comparison always evaluates to false [-Werror=tautological-compare]
  if (sp2->spe_default != sp2->spe_default) {
                       ^~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk about 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 5b0d4055542d02d79e8b2cd0079f0580027f87e4

commit  5b0d4055542d02d79e8b2cd0079f0580027f87e4
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-10T16:17:32.000Z

    8340 datadm: self-comparison always evaluates to false
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF