Project

General

Profile

Feature #8346

SES topology information needs to search STP Bridge ports

Added by Robert Mustacchi over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2017-06-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

The SES specification says that when a SATA disk is found, it updates the phy information in the following way:

  • It marks the SATA bit
  • It writes the WWN of the STP (SATA tunneling protocol) bridge port WWN

When the SATL layer allows us to get the underlying SATA GUID so we can construct a WWN, we will generally end up using that information. mpt_sas amd pmcs are drivers where we do this, while smrt is a driver where we don't because of firmware limitations. As such, when the ses module ends up going through and processing things, the WWN it has for a given port doesn't match any of the WWNs in place for the drives. As such, we don't end up matching up the bay with any disk.

The topology nodes already record this bridge-port property if it exists and it is in the topo disk information. As such, when we end up not matching any SAS address, we should take another pass and if any of the phys report that they're SATA, we'll then end up going through and trying to search for a disk that matches based on the bridge-port property.

History

#1

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed

git commit 8221efec02725289918c06a850adcd7393394c8b

commit  8221efec02725289918c06a850adcd7393394c8b
Author: Robert Mustacchi <rm@joyent.com>
Date:   2017-07-12T20:40:13.000Z

    8346 SES topology information needs to search STP Bridge ports
    8347 mpt_sas needs to set bridge-port property for SATA devices
    8348 mptsas_handle_topo_change() can return without locks held
    Reviewed by: Joshua M. Clulow <jmc@joyent.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF