Actions
Feature #8348
closed
mptsas_handle_topo_change() can return without locks held
Start date:
2017-06-05
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
The expectation of the mptsas_handle_topo_change() function is that it should always end up always returning with the mpt->m_mutex held, this is partly why it asserts that it has it. In addition, the calling function does a mutex_exit() a few lines later. The reality is that whenever this function returns, we need to make sure that we're entered the mutex.
Related issues
Updated by Electric Monk over 6 years ago
- Status changed from New to Closed
git commit 8221efec02725289918c06a850adcd7393394c8b
commit 8221efec02725289918c06a850adcd7393394c8b
Author: Robert Mustacchi <rm@joyent.com>
Date: 2017-07-12T20:40:13.000Z
8346 SES topology information needs to search STP Bridge ports
8347 mpt_sas needs to set bridge-port property for SATA devices
8348 mptsas_handle_topo_change() can return without locks held
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Toomas Soome <tsoome@me.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Updated by Marcel Telka about 5 years ago
- Related to Bug #9046: mptsas_handle_topo_change can return without its locks held added
Actions