Project

General

Profile

Actions

Bug #8349

closed

thrd_equal implements the wrong specification

Added by Robert Mustacchi about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2017-06-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While implementing thrd_equal(3C), as part of C11, I completely misread the standard. I accidentally reversed the conditions, meaning that 0 was success and non-zero was failure. However, in realize it's the exact opposite. Sigh.

Actions #1

Updated by Electric Monk about 5 years ago

  • Status changed from New to Closed

git commit cdcc9e2ce0563ac9f9076ee350d4fd008f61f1eb

commit  cdcc9e2ce0563ac9f9076ee350d4fd008f61f1eb
Author: Robert Mustacchi <rm@joyent.com>
Date:   2017-06-20T15:44:37.000Z

    8349 thrd_equal implements the wrong specification
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF