Bug #8393

bnxe: left shift of negative value and bad macro

Added by Toomas Soome 10 days ago. Updated 6 days ago.

Status:ClosedStart date:2017-06-15
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:driver - device drivers
Target version:-
Difficulty:Medium Tags:

Description

Build errors from gcc 6:

../../common/io/bnxe/577xx/drivers/common/include/debug.h:882:26: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
 #define ERR_IF(cond)(cond==TRUE)
                          ^
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:1234:8: note: in expansion of macro 'ERR_IF'
     if(ERR_IF(!pdev))

../../common/io/bnxe/577xx/common/bnxe_clc.c:11956:41: error: left shift of negative value [-Werror=shift-negative-value]
   vars->eee_status &= ~SHMEM_EEE_1G_ADV <<
                                         ^~
cc1: all warnings being treated as errors

History

#1 Updated by Electric Monk 6 days ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit cabd62a218e426e3dea29d3051d184458cdddbdf

commit  cabd62a218e426e3dea29d3051d184458cdddbdf
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-19T17:09:23.000Z

    8393 bnxe: left shift of negative value and bad macro
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom