Project

General

Profile

Actions
Copy link

Bug #8393

closed

bnxe: left shift of negative value and bad macro

Added by Toomas Soome over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2017-06-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors from gcc 6:

../../common/io/bnxe/577xx/drivers/common/include/debug.h:882:26: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
 #define ERR_IF(cond)(cond==TRUE)
                          ^
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:1234:8: note: in expansion of macro 'ERR_IF'
     if(ERR_IF(!pdev))

../../common/io/bnxe/577xx/common/bnxe_clc.c:11956:41: error: left shift of negative value [-Werror=shift-negative-value]
   vars->eee_status &= ~SHMEM_EEE_1G_ADV <<
                                         ^~
cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit cabd62a218e426e3dea29d3051d184458cdddbdf

commit  cabd62a218e426e3dea29d3051d184458cdddbdf
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-19T17:09:23.000Z

    8393 bnxe: left shift of negative value and bad macro
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF