Bug #8396

uts: vm_dep.h error: left shift of negative value

Added by Toomas Soome 2 months ago. Updated 2 months ago.

Status:ClosedStart date:2017-06-15
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:kernel
Target version:-
Difficulty:Medium Tags:

Description

Build error with gcc 6:

In file included from ../../common/vm/vm_pagelist.c:59:0:
../../common/vm/vm_pagelist.c: In function 'page_ctr_sub_internal':
../../i86pc/vm/vm_dep.h:70:36: error: left shift of negative value [-Werror=shift-negative-value]
  plcnt_inc_dec(pp, mtype, szc, -1l << PAGE_BSZS_SHIFT(szc), flags)
                                    ^
../../common/vm/vm_pagelist.c:879:2: note: in expansion of macro 'PLCNT_DECR'
  PLCNT_DECR(pp, mnode, mtype, pp->p_szc, flags);
  ^~~~~~~~~~
cc1: all warnings being treated as errors

History

#1 Updated by Electric Monk 2 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 567fb7ba1e336fc2eab74e747be1e7ac51f1a4ee

commit  567fb7ba1e336fc2eab74e747be1e7ac51f1a4ee
Author: Toomas Soome <tsoome@me.com>
Date:   2017-06-21T14:02:28.000Z

    8396 uts: vm_dep.h error: left shift of negative value
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom