Bug #8399

sun_fc: in C++11 destructors default to noexcept

Added by Toomas Soome about 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:2017-06-15
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:lib - userland libraries
Target version:-
Difficulty:Medium Tags:

Description

Build error with gcc 6:

../common/Handle.cc: In destructor 'Handle::~Handle()':
../common/Handle.cc:172:6: error: throw will always call terminate() [-Werror=terminate]
      throw;
      ^~~~~
../common/Handle.cc:172:6: note: in C++11 destructors default to noexcept
../common/Handle.cc:187:6: error: throw will always call terminate() [-Werror=terminate]
      throw;
      ^~~~~
../common/Handle.cc:187:6: note: in C++11 destructors default to noexcept
cc1plus: all warnings being treated as errors

History

#1 Updated by Electric Monk about 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 7f6d142fc0001e76967b1f047b6df5bc4c5d9082

commit  7f6d142fc0001e76967b1f047b6df5bc4c5d9082
Author: Toomas Soome <tsoome@me.com>
Date:   2017-07-28T18:22:53.000Z

    8399 sun_fc: in C++11 destructors default to noexcept
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom