Project

General

Profile

Bug #8457

libstmf: psStmfProp and psStmfPropVal may be used uninitialized

Added by Toomas Soome almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2017-07-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build error from gcc 6:

../common/store.c: In function 'iPsGetSetStmfProp':
../common/store.c:2397:6: error: 'psStmfProp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  if (scf_pg_get_property(pg, psStmfProp, prop) == -1) {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../common/store.c:2447:7: error: 'psStmfPropVal' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   if (scf_value_set_astring(value, psStmfPropVal) == -1) {
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk almost 3 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 8fd2e913f04a71b9e820a088819d5b3d5205945b

commit  8fd2e913f04a71b9e820a088819d5b3d5205945b
Author: Toomas Soome <tsoome@me.com>
Date:   2017-07-14T15:15:01.000Z

    8457 libstmf: psStmfProp and psStmfPropVal may be used uninitialized
    Reviewed by: Gary Mills <gary_mills@fastmail.fm>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF