Project

General

Profile

Bug #8459

i86pc: pci_tools.c variable might be clobbered

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
kernel
Start date:
2017-07-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build error from gcc 6:

    ../../i86pc/io/pci/pci_tools.c: In function 'pcitool_io_access':
    ../../i86pc/io/pci/pci_tools.c:678:6: error: variable 'rval' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
      int rval = SUCCESS;
          ^~~~
    ../../i86pc/io/pci/pci_tools.c: In function 'pcitool_mem_access':
    ../../i86pc/io/pci/pci_tools.c:766:6: error: variable 'rval' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
      int rval = DDI_SUCCESS;
          ^~~~

    ../../i86pc/io/pci/pci_tools.c: In function 'pcitool_io_access':
    ../../i86pc/io/pci/pci_tools.c:680:11: error: variable 'local_data' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
      uint64_t local_data;
               ^~~~~~~~~~
    ../../i86pc/io/pci/pci_tools.c: In function 'pcitool_mem_access':
    ../../i86pc/io/pci/pci_tools.c:768:11: error: variable 'local_data' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
      uint64_t local_data;
               ^~~~~~~~~~

    cc1: all warnings being treated as errors

#1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 1ee1bcba6f9a17099e11b5bb0d1eeab71c729aa3

commit  1ee1bcba6f9a17099e11b5bb0d1eeab71c729aa3
Author: Toomas Soome <tsoome@me.com>
Date:   2017-07-10T13:07:00.000Z

    8459 i86pc: pci_tools.c variable might be clobbered
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Aurélien Larcher <aurelien.larcher@gmail.co>
    Reviewed by: Gary Mills <gary_mills@fastmail.fm>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF