Project

General

Profile

Actions

Bug #8497

closed

ficl: ficlStackCheckNospill should be static inline

Added by Toomas Soome about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2017-07-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

The problem revealed by gcc 7 build. The ficlStackCheckNospill is declared inline and without static, gcc 7 will inject the symbol as unknown global as the function body is not created.

Actions #1

Updated by Electric Monk almost 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 0c950529ae1558b3b4983f2eb6d4dd664ddfa424

commit  0c950529ae1558b3b4983f2eb6d4dd664ddfa424
Author: Toomas Soome <tsoome@me.com>
Date:   2017-10-19T15:18:31.000Z

    8497 ficl: ficlStackCheckNospill should be static inline
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF