Project

General

Profile

Bug #8499

ficl: this statement may fall through

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2017-07-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The issue revealed by gcc 7 build:

    /code/illumos-gate/usr/src/common/ficl/vm.c:149:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
        ficlVmOptimizeJumpToJump(vm, destination);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /code/illumos-gate/usr/src/common/ficl/vm.c:150:3: note: here
       case ficlInstructionBranchParen:
       ^~~~

    /code/illumos-gate/usr/src/common/ficl/primitives.c:419:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
         base = 16;
         ~~~~~^~~~
    /code/illumos-gate/usr/src/common/ficl/primitives.c:420:4: note: here
        case 'u':
        ^~~~
    /code/illumos-gate/usr/src/common/ficl/primitives.c:422:21: error: this statement may fall through [-Werror=implicit-fallthrough=]
         unsignedInteger = 1; /* true */
         ~~~~~~~~~~~~~~~~^~~
    /code/illumos-gate/usr/src/common/ficl/primitives.c:423:4: note: here
        case 'd':
        ^~~~
    /code/illumos-gate/usr/src/common/ficl/primitives.c:439:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
         actualLength = 1;
         ~~~~~~~~~~~~~^~~
    /code/illumos-gate/usr/src/common/ficl/primitives.c:440:4: note: here
        default:
        ^~~~~~~

    /code/illumos-gate/usr/src/common/ficl/emu/loader_emu.c:1148:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
       subtopic = strdup(argv[2]);
       ~~~~~~~~~^~~~~~~~~~~~~~~~~
    /code/illumos-gate/usr/src/common/ficl/emu/loader_emu.c:1149:2: note: here
      case 2:
      ^~~~

    /code/illumos-gate/usr/src/common/ficl/float.c:294:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (c == '+') {
           ^
    /code/illumos-gate/usr/src/common/ficl/float.c:302:3: note: here
       case FPS_ININT:
       ^~~~
    /code/illumos-gate/usr/src/common/ficl/float.c:339:14: error: this statement may fall through [-Werror=implicit-fallthrough=]
        } else if (c == '+') {
                  ^
    /code/illumos-gate/usr/src/common/ficl/float.c:347:3: note: here
       case FPS_INEXP:
       ^~~~

    cc1: all warnings being treated as errors

#1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d65dfb0a6855414a1ff916b896e8be0fbe0d212a

commit  d65dfb0a6855414a1ff916b896e8be0fbe0d212a
Author: Toomas Soome <tsoome@me.com>
Date:   2017-07-30T16:08:41.000Z

    8499 ficl: this statement may fall through
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF