Project

General

Profile

Bug #8501

ixgbe has uninitialized kstat fields

Added by Robert Mustacchi about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2017-07-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

ixgbe creates a kstat based on the ixgbe_stat structure – but this structure has several fields that are only initialized if IXGBE_DEBUG is set rx_frame_error, rx_cksum_error, rx_exceed_pkt, tx_overload, tx_fail_no_tbd, tx_fail_no_tcb, tx_fail_dma_bind, tx_reschedule. The upshot is a zero'ed kstat that gets exported to user-level, potentially confusing kstat consumers that don't handle the edge case.

History

#1

Updated by Electric Monk about 2 years ago

  • Status changed from New to Closed

git commit a9bfd41d542f15c474711abb8b0ca66a4cef9918

commit  a9bfd41d542f15c474711abb8b0ca66a4cef9918
Author: Ryan Zezeski <rpz@joyent.com>
Date:   2017-08-04T20:39:56.000Z

    8501 ixgbe has uninitialized kstat fields
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF