Project

General

Profile

Feature #8514

Reimport mDNSResponder-625.41.2 with include guards, and update documentation

Added by C Fraire over 2 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2017-07-19
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

It would be helpful for continual synchronization of libdns_sd et al to Apple's version (and code review thereof) if the third-party code was imported fully, and illumos-specific revisions were contained in #ifdef-else sections under a new macro, _ILLUMOS_MDNS.

For man pages, the equivalent technique can be used in comment-sections using the same _ILLUMOS_MDNS keyword.

Also, the libdns_sd README needs updating, as several of the documented, "Solaris"-specific changes are defunct given the version of mDNSResponder, 625.41.2, which was last imported.

History

#1

Updated by Toomas Soome over 2 years ago

C Fraire wrote:

It would be helpful for continual synchronization of libdns_sd et al to Apple's version (and code review thereof) if the third-party code was imported fully, and illumos-specific revisions were contained in #ifdef-else sections under a new macro, _ILLUMOS_MDNS.

For man pages, the equivalent technique can be used in comment-sections using the same _ILLUMOS_MDNS keyword.

Also, the libdns_sd README needs updating, as several of the documented, "Solaris"-specific changes are defunct given the version of mDNSResponder, 625.41.2, which was last imported.

I did the facelift on the current version and took the simple path; I too think the more appropriate way would have something like freebsd is doing - to have the full third party package in ../contrib tree, and build Makefiles where you need to build the specific component. This way it is easier to build the patches to original code and import the updates.

Also available in: Atom PDF