Project

General

Profile

Bug #8599

Snapshots don't preserver user properties

Added by Alan Somers over 3 years ago. Updated about 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2017-08-31
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

If you explicitly set a user property on a snapshot, then it will be preserved, as expected. However, if you set a user property on the filesystem, snapshot that filesystem, then change the property, then the snapshot's property will incorrectly have the new value. Builtin properties don't have this problem.

  1. zpool create foo /tmp/da0
  2. zfs set x:y=1 foo
  3. zfs snapshot foo@1
  4. zfs set x:y=2 foo
  5. zfs set compress=on foo
  6. zfs snapshot foo@2
  7. zfs list -o name,compress,x:y -r -t all foo
    NAME COMPRESS X:Y
    foo on 2
    foo@1 - 2
    foo@2 - 2

foo@1 should've had "1" for the value of X:Y, but instead it had "2".

#1

Updated by Andriy Gapon about 3 years ago

I think that this is expected behaviour.

$ zfs get x:x rpool/x@s
NAME       PROPERTY  VALUE  SOURCE
rpool/x@s  x:x       1      inherited from rpool/x

If the property is inherited, then any changes to rpool/x are obviously reflected in rpool/x@s.

#2

Updated by Alan Somers about 3 years ago

Is it expected behavior that builtin properties and user properties would inherit differently?

Also available in: Atom PDF