Project

General

Profile

Actions
Copy link

Bug #8601

closed

memory leak in get_special_prop()

Added by Prakash Surya almost 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2017-09-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

after running "zfstest" and then using "reboot -d" and "::findleaks", there's a couple of leaks like the following:

kmem_alloc_8 leak: 2 buffers, 8 bytes each, 16 bytes total
ADDR BUFADDR TIMESTAMP THREAD
CACHE LASTLOG CONTENTS
ffffff071a067978 ffffff071a0416c0 9b097add290 ffffff002126fc40
ffffff06e1628888 ffffff06f0e0b440 ffffff06f7592ea0
kmem_cache_alloc_debug+0x2e0
kmem_cache_alloc+0xdd
kmem_alloc+0x4b
ddi_strdup+0x5f
strdup+0x13
get_receive_resume_stats_impl+0x31c
get_special_prop+0x192
zcp_get_system_prop+0x79
zcp_get_prop+0xab
luaD_precall+0x1fd
luaV_execute+0x355
luaD_call+0x88
f_call+0x1d
luaD_rawrunprotected+0x69
luaD_pcall+0x55

I've attached a copy of the output of "::findleaks -df" to this bug, which contains these leaks.

Files

findleaks-after.txt (7.14 KB) findleaks-after.txt Prakash Surya, 2017-09-01 04:01 PM
Actions
Copy link
 #1

Updated by Electric Monk almost 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit e19b450bec203d8be04447ea476d7a86b36d63a1

commit  e19b450bec203d8be04447ea476d7a86b36d63a1
Author: John Gallagher <john.gallagher@delphix.com>
Date:   2018-09-18T20:51:43.000Z

    8601 memory leak in get_special_prop()
    Reviewed by: Serapheim Dimitropoulos <serapheim.dimitro@delphix.com>
    Reviewed by: Sara Hartse <sara.hartse@delphix.com>
    Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
    Reviewed by: Matt Ahrens <matt@delphix.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF