Project

General

Profile

Bug #8607

zfs: variable set but not used

Added by Toomas Soome about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
zfs - Zettabyte File System
Start date:
2017-09-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

gcc 6 build issue, debug build needs to havevariables to be marked unused:

    ../../common/fs/zfs/zfs_ioctl.c: In function 'zfs_ioc_send_space':
    ../../common/fs/zfs/zfs_ioctl.c:5578:12: error: variable 'embedok' set but not used [-Werror=unused-but-set-variable]
      boolean_t embedok;
                ^~~~~~~
    ../../common/fs/zfs/zfs_ioctl.c:5576:12: error: variable 'largeblockok' set but not used [-Werror=unused-but-set-variable]
      boolean_t largeblockok;
                ^~~~~~~~~~~~
    ../../../uts/common/fs/zfs/dsl_pool.c: In function 'dsl_pool_create':
    ../../../uts/common/fs/zfs/dsl_pool.c:390:12: error: variable 'os' set but not used [-Werror=unused-but-set-variable]
      objset_t *os;
                ^~
    cc1: all warnings being treated as errors

History

#1

Updated by Toomas Soome about 2 years ago

  • Description updated (diff)
#2

Updated by Electric Monk almost 2 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit b852c2f54326f8ac1daa372a88bfe951dd7e20ed

commit  b852c2f54326f8ac1daa372a88bfe951dd7e20ed
Author: Toomas Soome <tsoome@me.com>
Date:   2017-11-03T21:31:27.000Z

    8607 zfs: variable set but not used
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF