pcplusmp shouldn't support x2APIC mode
We are currently in the weird situation to have two platform modules dealing with APIC and x2APIC, namely pcplusmp and apix. Initially there was only pcplusmp that handled the APIC. Then support for x2APIC was added to pcplusmp. A little later a new module apix was introduced to deal with systems supporting x2APIC in both legacy APIC and x2APIC modes. Ever since then all systems supporting x2APIC were using apix, not pcplusmp.
The two modules share a fair bit of code, which isn't surprising as both support the legacy APIC mode. But there really is no reason for pcplusmp to have the ability to work in x2APIC mode. It's relatively easy to garbage-collect the x2APIC support from pcplusmp by moving a few pieces of code around with no functional changes.
Updated by Hans Rosenfeld almost 5 years ago
- I have an AMD family 0x10 system that does not support x2apic, so it's using the pcplusmp module. There were no problems with the updated pcplusmp module, I saw no warnings in the log and the kmdb ::interrupts output didn't change significantly.
- Another system I tested on is a Fujitsu Primergy TX150S8 which uses the apix module. I wasn't able to see any regressions there either. My workstations also uses apix and has x2apic enabled by default, and I didn't notice any unexpected behavior their, too.
The change also has been in illumos-joyent since May or so.
Updated by Electric Monk almost 5 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 583cd3308017d0e5a17e7164fbee4c20ed04b165 Author: Hans Rosenfeld <firstname.lastname@example.org> Date: 2017-09-20T18:35:31.000Z 8620 pcplusmp shouldn't support x2APIC mode Reviewed by: Robert Mustacchi <email@example.com> Reviewed by: Jerry Jelinek <firstname.lastname@example.org> Approved by: Garrett D'Amore <email@example.com>