Project

General

Profile

Bug #8626

make pcplusmp and apix warning-free

Added by Hans Rosenfeld about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
2017-09-07
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

Both pcplusmp and apix have currently a bunch of gcc warnings disabled, and pcplusmp also disables a few lint warnings.

The gcc warnings are about a few uninitialized variables, but it turns out that gcc is confused here. Turning off the optimizer makes those warnings disappear. After checking the code and making sure those variables are never used uninitialized I think it's reasonable to initialize them to 0 to shut up gcc.

The lint warnings are mostly about implicit narrowing conversions. After checking that these are actually safe I turned them into explicit casts.

History

#1

Updated by Hans Rosenfeld about 2 years ago

Webrev: https://grumpf.hope-2000.org/illumos-8626/

This change has been in illumos-joyent since around June.

#2

Updated by Electric Monk about 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 30acb30daf662150e9e016113303bd74f2379dfc

commit  30acb30daf662150e9e016113303bd74f2379dfc
Author: Hans Rosenfeld <hans.rosenfeld@joyent.com>
Date:   2017-09-15T16:04:29.000Z

    8626 make pcplusmp and apix warning-free
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF