Project

General

Profile

Bug #8639

libofmt doesn't properly build its lint library

Added by Robert Mustacchi over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2017-09-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While working on 8507, I noticed the following lint issue:

"/ws/rm/ofmt/usr/src/lib/libofmt/common/ofmt.c", line 635: warning: name defined but never used: ofmt_check in ofmt.c(635) (E_NAME_DEF_NOT_USED2)

This was somewhat perplexing. After all the lint library was properly including the needed header file (ofmt.h) to indicate it was all to be part of the lint library. Digging into the Makefile.com file, there was a missing piece that's generally required for libraries:

+$(LINTLIB)     := SRCS = $(SRCDIR)/$(LINTSRC)

With this in place, the lint library then failed to build beacuse lint couldn't parse the declaration uint_t. This is because the ofmt.h header file does not include any headers that would define this type.


Related issues

Related to illumos gate - Bug #8640: libofmt needs to include required headersClosedRobert Mustacchi2017-09-08

Actions
Related to illumos gate - Bug #8507: dladm show-link segfaults if you specify too many fieldsClosedBryan Cantrill2017-07-18

Actions

Also available in: Atom PDF