Project

General

Profile

Actions
Copy link

Bug #8659

closed

ata: unused but set warnings with GCC 5.X

Added by Andrew Stormont almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2017-09-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

In ata_init_pm there are two variables (pmc_name and pmc) with are only used when ATA_USE_AUTOPM is defined.
In sil3xxx_init_controller there are is one variable (sfiscfg_val) which is only used when ATA_DEBUG is defined.

Actions
Copy link
 #1

Updated by Andrew Stormont almost 5 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Andrew Stormont almost 5 years ago

NOTE: ADBG_WARN is a no-op when ATA_DEBUG is not defined which is why I changed the ifdef from DEBUG to ATA_DEBUG.

Actions
Copy link
 #4

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 6e6c7d67bf5ba2efa13619acd59395d0f278ee75

commit  6e6c7d67bf5ba2efa13619acd59395d0f278ee75
Author: Andrew Stormont <astormont@racktopsystems.com>
Date:   2018-03-11T06:32:26.000Z

    8659 ata: unused but set warnings with GCC 5.X
    Reviewed by: Ken Mays <maybird1776@yahoo.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Actions
Copy link

Also available in: Atom PDF