Actions
Bug #8681
closed
loader: bios loader should check the smap while loading the modules
Start date:
2017-09-22
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
The current loading is built assuming contiguous address map above 1MB line, and the only rule on module placement is that new module should start from page aligned address. However, apparently there already are BIOS systems, where we can encounter holes, and therefore we also need to consult with memory smap list to avoid the holes.
This bug was discovered and the fix verified with AMD Ryzen system, with BIOS firmware. Note, the similar check must also be implemented for UEFI loader and kernel dboot and locore (fakebop) module, but to keep the changes simple, we will address those components in separate.
Related issues
Updated by Gary Mills over 4 years ago
- Related to Bug #8680: Time of Day clock error added
Updated by Gary Mills over 4 years ago
- Related to Bug #8679: failed to attach AMD IOMMU added
Updated by Electric Monk about 4 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit 8600fd4d298d030074e320640089504e8d45668e
commit 8600fd4d298d030074e320640089504e8d45668e
Author: Toomas Soome <tsoome@me.com>
Date: 2017-11-03T17:09:18.000Z
8681 loader: bios loader should check the smap while loading the modules
Reviewed by: Yuri Pankov <yuripv@gmx.com>
Reviewed by: Ken Mays <maybird1776@yahoo.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Actions