Bug #8681

loader: bios loader should check the smap while loading the modules

Added by Toomas Soome 7 months ago. Updated 6 months ago.

Status:ClosedStart date:2017-09-22
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:bootloader
Target version:-
Difficulty:Medium Tags:

Description

The current loading is built assuming contiguous address map above 1MB line, and the only rule on module placement is that new module should start from page aligned address. However, apparently there already are BIOS systems, where we can encounter holes, and therefore we also need to consult with memory smap list to avoid the holes.

This bug was discovered and the fix verified with AMD Ryzen system, with BIOS firmware. Note, the similar check must also be implemented for UEFI loader and kernel dboot and locore (fakebop) module, but to keep the changes simple, we will address those components in separate.


Related issues

Related to illumos gate - Bug #8680: Time of Day clock error Closed 2017-09-22
Related to illumos gate - Bug #8679: failed to attach AMD IOMMU New 2017-09-22

History

#1 Updated by Gary Mills 7 months ago

  • Related to Bug #8680: Time of Day clock error added

#2 Updated by Gary Mills 7 months ago

  • Related to Bug #8679: failed to attach AMD IOMMU added

#3 Updated by Electric Monk 6 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 8600fd4d298d030074e320640089504e8d45668e

commit  8600fd4d298d030074e320640089504e8d45668e
Author: Toomas Soome <tsoome@me.com>
Date:   2017-11-03T17:09:18.000Z

    8681 loader: bios loader should check the smap while loading the modules
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Ken Mays <maybird1776@yahoo.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom