Project

General

Profile

Bug #8695

inet/ip/ip6_ire.c: variable 'masked_addr' set but not used

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2017-10-03
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

gcc 6 build issue:

    ../../common/inet/ip/ip6_ire.c: In function 'ire_match_args_v6':
    ../../common/inet/ip/ip6_ire.c:690:13: error: variable 'masked_addr' set but not
     used [-Werror=unused-but-set-variable]
      in6_addr_t masked_addr;
                 ^~~~~~~~~~~
    cc1: all warnings being treated as errors

and indeed, the V6_MASK_COPY() macro does not copy the mask, but is using mask to create masked address, but this masked address is not used in this function.

#1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 86e908a90d84b25fff11d115c73c14e4634bb00b

commit  86e908a90d84b25fff11d115c73c14e4634bb00b
Author: Toomas Soome <tsoome@me.com>
Date:   2017-10-09T14:07:39.000Z

    8695 inet/ip/ip6_ire.c: variable 'masked_addr' set but not used
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF