Project

General

Profile

Bug #872

remove duplicate daemon() definitions

Added by Rich Lowe over 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
-
Start date:
2011-03-30
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

Various sources have their own daemon() implementation, with the integration of
4471189 "should have 4.4BSD's daemon() utility function" in 2009, these are all unnecessary and should be removed.

History

#1

Updated by Rich Lowe over 8 years ago

  • Assignee deleted (Rich Lowe)
  • Difficulty set to Bite-size
#2

Updated by Ryan Zezeski almost 5 years ago

  • Assignee set to Ryan Zezeski

webrev: http://zinascii.com/pub/illumos/webrevs/872/

Besides the public daemon symbol in libc, two other libs define
private daemon symbols.

1. mech_krb5
2. libresolv2

According to README.mapfiles a private symbol may be removed at any
time, though it is courteous to make sure it's not in wide use first.
Given that daemon is now part of libc, and everything must link against
libc, I don't see a reason to keep these symbols defined.

The mDNS code also contains its own private daemon definition but since
that is a command, and the source is copied from Apple, I decided to
leave it alone.

pbchk complains about copyrights needing update but all I did was remove
code so that seems silly.

cstyle goes bonkers against port_after.h but it didn't feel right to
change that entire file for this ticket. Happy to make it cstyle clean
if someone feels otherwise.

#3

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit ce3c309f71f6893197099bfac06adb66f0870d7d

commit  ce3c309f71f6893197099bfac06adb66f0870d7d
Author: Ryan Zezeski <ryan@zinascii.com>
Date:   2015-02-22T21:16:15.000Z

    872 remove duplicate daemon() definitions
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Approved by: Richard Lowe <richlowe@richlowe.net>

#4

Updated by Electric Monk over 4 years ago

git commit eb459a53dd5ee2db4c6c3eb63fe988a901174fc2

commit  eb459a53dd5ee2db4c6c3eb63fe988a901174fc2
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2015-02-25T17:12:12.000Z

    872 remove duplicate daemon() definitions (backward compatibility)

Also available in: Atom PDF