Project

General

Profile

Actions

Bug #8766

closed

pcitool: typedef locally defined but not used

Added by Toomas Soome almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2017-11-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

Debug mode build error with gcc 6:

    ../pcitool_ui.c: In function 'parse_nexus_opts':
    ../pcitool_ui.c:904:4: error: typedef 'nexus_opts_index_t' locally defined but not used [-Werror=unused-local-typedefs]
      } nexus_opts_index_t;
        ^~~~~~~~~~~~~~~~~~
    ../pcitool_ui.c: In function 'parse_device_opts':
    ../pcitool_ui.c:1076:4: error: typedef 'bdf_opts_index_t' locally defined but not used [-Werror=unused-local-typedefs]
      } bdf_opts_index_t;
        ^~~~~~~~~~~~~~~~
    ../pcitool_ui.c: In function 'parse_probeone_opts':
    ../pcitool_ui.c:1444:4: error: typedef 'p1_bdf_opts_index_t' locally defined but not used [-Werror=unused-local-typedefs]
      } p1_bdf_opts_index_t;
        ^~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors
    *** Error code 1
    dmake: Fatal error: Command failed for target `pcitool_ui.o'

Actions #1

Updated by Electric Monk almost 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 0803869a9bc0aff1c81287ac6eae15943cbba545

commit  0803869a9bc0aff1c81287ac6eae15943cbba545
Author: Toomas Soome <tsoome@me.com>
Date:   2017-11-16T15:42:48.000Z

    8766 pcitool: typedef locally defined but not used
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Jason King <jason.king@joyent.com>
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF