Project

General

Profile

Actions

Bug #8768

closed

lib/hal: variable set but not used

Added by Toomas Soome almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2017-11-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Debug build errors from gcc 6:

    ../common/libhal-storage.c: In function 'libhal_volume_policy_compute_display_name':
    ../common/libhal-storage.c:361:23: error: variable 'drive_cdrom_caps' set but not used [-Werror=unused-but-set-variable]
      LibHalDriveCdromCaps drive_cdrom_caps;
                           ^~~~~~~~~~~~~~~~
    ../common/libhal-storage.c:359:14: error: variable 'drive_is_hotpluggable' set but not used [-Werror=unused-but-set-variable]
      dbus_bool_t drive_is_hotpluggable;
                  ^~~~~~~~~~~~~~~~~~~~~
    ../common/libhal-storage.c:357:14: error: variable 'vendor' set but not used [-Werror=unused-but-set-variable]
      const char *vendor;
                  ^~~~~~
    ../common/libhal-storage.c:356:14: error: variable 'model' set but not used [-Werror=unused-but-set-variable]
      const char *model;
                  ^~~~~
    ../common/libhal-storage.c: In function 'mopts_collect':
    ../common/libhal-storage.c:1900:7: error: variable 'type' set but not used [-Werror=unused-but-set-variable]
       int type;
           ^~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk almost 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 8629b981ede6d47b0583ca2d3e62baeaa4f26e93

commit  8629b981ede6d47b0583ca2d3e62baeaa4f26e93
Author: Toomas Soome <tsoome@me.com>
Date:   2017-11-10T15:48:41.000Z

    8768 lib/hal: variable set but not used
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Ryan Zezeski <rpz@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF