Actions
Bug #8776
closed
krb5kdc: right-hand operand of comma expression has no effect
Start date:
2017-11-06
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
Debug build error from gcc 6:
network.c: In function 'delete_fd':
network.c:218:37: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
(set.data[idx] = set.data[--set.n], 0)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
network.c:342:6: note: in expansion of macro 'DEL'
DEL(connections, i);
^~~
network.c: In function 'closedown_network':
network.c:218:37: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
(set.data[idx] = set.data[--set.n], 0)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
network.c:1136:2: note: in expansion of macro 'DEL'
DEL (connections, i);
^~~
cc1: all warnings being treated as errors
Updated by Electric Monk over 4 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit 44d74681b047548dfbd9a7b3f4e269c98c3b393c
commit 44d74681b047548dfbd9a7b3f4e269c98c3b393c
Author: Toomas Soome <tsoome@me.com>
Date: 2017-11-14T16:23:20.000Z
8776 krb5kdc: right-hand operand of comma expression has no effect
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
Reviewed by: Gary Mills <gary_mills@fastmail.fm>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions