Project

General

Profile

Actions

Bug #8842

closed

libmail: right-hand operand of comma expression has no effect

Added by Toomas Soome almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2017-11-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Debug build error from gcc 6:

    ../common/s_string.c: In function 's_tok':
    ../inc/s_string.h:60:44: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
     #define s_restart(s) ((s)->ptr = (s)->base , (s))
                          ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
    ../common/s_string.c:293:3: note: in expansion of macro 's_restart'
       s_restart(to);
       ^~~~~~~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk almost 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d87d03b4c0f66bf125e607ef8b0d9c5481040d20

commit  d87d03b4c0f66bf125e607ef8b0d9c5481040d20
Author: Toomas Soome <tsoome@me.com>
Date:   2017-11-27T16:15:21.000Z

    8842 libmail: right-hand operand of comma expression has no effect
    Reviewed by: Yuri Pankov <yuripv@gmx.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF