Bug #8961

SPA load/import should tell us why it failed

Added by Prakash Surya 8 months ago. Updated 8 months ago.

Status:ClosedStart date:2018-01-10
Priority:NormalDue date:
Assignee:Prakash Surya% Done:

100%

Category:zfs - Zettabyte File System
Target version:-
Difficulty:Medium Tags:needs-triage

Description

When we fail to open or import a storage pool, we typically don't get any
additional diagnostic information, just "no pool found" or "can not import".

While there may be no additional user-consumable information, we should at
least make this situation easier to debug/diagnose for developers and support.
For example, we could start by using `zfs_dbgmsg()` to log each thing that we
try when importing, and which things failed. E.g. "tried uberblock of txg X
from label Y of device Z". Also, we could log each of the stages that we go
through in `spa_load_impl()`.

History

#1 Updated by Electric Monk 8 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 3ee8c80c747c4aa3f83351a6920f30c411236e1b

commit  3ee8c80c747c4aa3f83351a6920f30c411236e1b
Author: Pavel Zakharov <pavel.zakharov@delphix.com>
Date:   2018-02-06T17:36:45.000Z

    8961 SPA load/import should tell us why it failed
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom