Project

General

Profile

Actions

Feature #8974

closed

fac_prov_ipmi should support binding by entity id and instance

Added by Rob Johnston over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2018-01-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The fac_prov_enumerator topo module is responsible for (among other things) enumerating facility nodes for sensors via IPMI. In order to discover which sensors are associated with a given topo node, it looks for the name of any IPMI sensor data repository (SDR) record and pulls the entity id and instance off of it. It then iterates through all of the full and compact sensor SDR records that have a matching entity id and instance and creates a sensor facility node for them.

The problem with binding via entity names is they are arbitrary and vary from platform to platform. Worse still, they can even vary on the same platform based on the service processor firmware version, so even if we hard-code the entity names in a platform-specific topo map, we can still get broken. It would be better to bind on the entity ID and instance as those are numeric values whose semantics are more tightly specified by the IPMI specification.

Actions #1

Updated by Rob Johnston over 3 years ago

See comments in Issue 8975 for how these changes were tested.

Actions #2

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 8f022dd6c1ebe3edc269726bf537617e665df32f

commit  8f022dd6c1ebe3edc269726bf537617e665df32f
Author: Rob Johnston <rob.johnston@joyent.com>
Date:   2018-01-23T21:33:23.000Z

    8967 libipmi: add support for GET_CHASSIS_STATUS command
    8974 fac_prov_ipmi should support binding by entity id and instance
    8975 ipmi topo plugin should automatically enumerate sensors on nodes it enumerates
    8976 ipmi enumerator should include FRU identity information in FMRI authority
    8977 ipmi enumerator doesn't always enumerate nested entities
    8978 Add topo facility method for controlling chassis ident indicator
    Reviewed by: Yuri Pankov <yuripv@icloud.com>
    Reviewed by: Ben Sims <bensims@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF