Project

General

Profile

Actions

Bug #8978

closed

Add topo facility method for controlling chassis ident indicator

Added by Rob Johnston almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2018-01-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

This CR will cover the work to add a new facility method (chassis_ident_mode) to the fac_prov_ipmi facility provider module which can be used to get/set the mode of the chassis identify indicator. This will leverage the new interface being added by issue #8967.

Actions #1

Updated by Rob Johnston almost 4 years ago

To test the change, I wrote a CLI (topo-indicator) that uses the topo interface being added by this CR to get/set the state of the chassis identify indicator. The code for that CLI is here:

https://github.com/rejohnst/illumos-toolbox/blob/master/fma/topo-indicator/topo-indicator.c

I used the above utility to toggle the chassis locate indicator on/off and also retrieve the current state. This was performed on a handful of SuperMicro and Dell test rigs that I had physical access to, so I was able visually verify the state of the indicator. I also cross-referenced the state with the state as reported directly from IPMI (see output below)

[root@lava /var/tmp]# ./chassis-ident -t bmc -m get
chassis identify is off

[root@lava /var/tmp]# ./topo-indicator -m get -t locate "*chassis=0" 
Found node: hc://:product-id=SSG-2028R-ACR24L:server-id=lava:chassis-id=S194308X7333203/chassis=0
locate LED mode is OFF

[root@lava /var/tmp]# ./topo-indicator -m on -t locate "*chassis=0" 
Found node: hc://:product-id=SSG-2028R-ACR24L:server-id=lava:chassis-id=S194308X7333203/chassis=0
locate LED mode set to ON

[root@lava /var/tmp]# ./chassis-ident -t bmc -m get
chassis identify is on

[root@lava /var/tmp]# ./topo-indicator -m off -t locate "*chassis=0" 
Found node: hc://:product-id=SSG-2028R-ACR24L:server-id=lava:chassis-id=S194308X7333203/chassis=0
locate LED mode set to OFF

[root@lava /var/tmp]# ./chassis-ident -t bmc -m get
chassis identify is off
Actions #2

Updated by Electric Monk almost 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 8f022dd6c1ebe3edc269726bf537617e665df32f

commit  8f022dd6c1ebe3edc269726bf537617e665df32f
Author: Rob Johnston <rob.johnston@joyent.com>
Date:   2018-01-23T21:33:23.000Z

    8967 libipmi: add support for GET_CHASSIS_STATUS command
    8974 fac_prov_ipmi should support binding by entity id and instance
    8975 ipmi topo plugin should automatically enumerate sensors on nodes it enumerates
    8976 ipmi enumerator should include FRU identity information in FMRI authority
    8977 ipmi enumerator doesn't always enumerate nested entities
    8978 Add topo facility method for controlling chassis ident indicator
    Reviewed by: Yuri Pankov <yuripv@icloud.com>
    Reviewed by: Ben Sims <bensims@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF