Project

General

Profile

Bug #9035

zfs: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
2018-02-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue revealed by gcc 7:

    ../../../uts/common/fs/zfs/lua/ltable.c:485:23: error: this statement may fall t
    hrough [-Werror=implicit-fallthrough=]
         case LUA_TNUMBER: {
                           ^
    ../../../uts/common/fs/zfs/lua/ltable.c:493:5: note: here
         default: {
         ^~~~~~~

    ../../../uts/common/fs/zfs/lua/lstrlib.c:516:16: error: this statement may fall through [-Werror=implicit-fallthrough=]
                   s++;  /* 1 match already done */
                   ~^~
    ../../../uts/common/fs/zfs/lua/lstrlib.c:518:13: note: here
                 case '*':  /* 0 or more repetitions */
                 ^~~~

    ../../../uts/common/fs/zfs/lua/lgc.c:679:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
           G(L)->strt.nuse--;
    ../../../uts/common/fs/zfs/lua/lgc.c:681:5: note: here
         case LUA_TLNGSTR: {
         ^~~~

    ../../../uts/common/fs/zfs/lua/llex.c:475:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
             else if (!lisdigit(ls->current)) return '.';
                     ^
    ../../../uts/common/fs/zfs/lua/llex.c:478:7: note: here
           case '0': case '1': case '2': case '3': case '4':
           ^~~~

    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 46ac8fdfc5a1f9d8240c79a6ae5b2889cbe83553

commit  46ac8fdfc5a1f9d8240c79a6ae5b2889cbe83553
Author: Toomas Soome <tsoome@me.com>
Date:   2018-02-07T16:42:36.000Z

    9035 zfs: this statement may fall through
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF