Project

General

Profile

Actions

Bug #9037

closed

pfexecd: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-02-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Issue found by gcc 7 build:

    pfexecd.c:120:19: error: this statement may fall through [-Werror=implicit-fallthrough=]
        regexpr[len++] = '\\';
        ~~~~~~~~~~~~~~~^~~~~~
    pfexecd.c:121:3: note: here
       default:
       ^~~~~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2dedcc4ffd203141c363762ff9947921e80b860c

commit  2dedcc4ffd203141c363762ff9947921e80b860c
Author: Toomas Soome <tsoome@me.com>
Date:   2018-02-07T20:50:25.000Z

    9037 pfexecd: this statement may fall through
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF