Project

General

Profile

Feature #9045

Clean up mpt_sas compiler warnings

Added by Robert Mustacchi over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
2018-02-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

While building, I stumbled across the fact that mpt_sas non-debug build had several -Wempty-body warnings from the compiler. This goes through and fixes several of the easier warnings such that mpt_sas can be a more reliable part. With the exception of the -Wempty-body warnings, the rest of these did not seem to constitute major problems.

See testing notes in 9044.

History

#1

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed

git commit e89016e771abb6871cb08b54316d9a1a826a9193

commit  e89016e771abb6871cb08b54316d9a1a826a9193
Author: Robert Mustacchi <rm@joyent.com>
Date:   2018-04-04T20:15:13.000Z

    9044 Need support for mpt_sas tri-mode parts
    9045 Clean up mpt_sas compiler warnings
    9046 mptsas_handle_topo_change can return without its locks held
    9047 workaround SAS3408 firmware issue
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@joyent.com>
    Reviewed by: Albert Lee <trisk@forkgnu.org>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF