Project

General

Profile

Actions

Bug #9046

closed

mptsas_handle_topo_change can return without its locks held

Added by Robert Mustacchi over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
2018-02-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

In the mptsas_handle_topo_change() there is an invariant that the mptsas_t m_mutex member should be held when entering and leaving that function. Unfortunately, there are several cases in this function where it is dropped, but not entered again.

See 9044 for testing notes.


Related issues

Related to illumos gate - Feature #8348: mptsas_handle_topo_change() can return without locks heldClosedRobert Mustacchi2017-06-05

Actions
Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed

git commit e89016e771abb6871cb08b54316d9a1a826a9193

commit  e89016e771abb6871cb08b54316d9a1a826a9193
Author: Robert Mustacchi <rm@joyent.com>
Date:   2018-04-04T20:15:13.000Z

    9044 Need support for mpt_sas tri-mode parts
    9045 Clean up mpt_sas compiler warnings
    9046 mptsas_handle_topo_change can return without its locks held
    9047 workaround SAS3408 firmware issue
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@joyent.com>
    Reviewed by: Albert Lee <trisk@forkgnu.org>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions #2

Updated by Marcel Telka almost 3 years ago

  • Related to Feature #8348: mptsas_handle_topo_change() can return without locks held added
Actions

Also available in: Atom PDF