Project

General

Profile

Feature #9051

loader should ignore active multi_vdev_crash_dump feature on zpool

Added by Robert Mustacchi almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2018-02-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Currently the new bootloader ("loader") won't mount a zpool with the multi_vdev_crash_dump feature active (i.e. you have an actual dump zvol on the pool using it). Since the loader doesn't need to touch the zvol in question, it should be safe to just make it ignore it by adding it to features_for_read in zfsimpl.c.

Tested this by building it in staging and pulling it down onto a box that boots from its zpool. The box has no usb key, so it boots from a kernel+boot_archive stored in the pool at /zones/boot/*.

  • Pulled down new gptzfsboot and zfsloader, installed with the installboot command
  • Rebooted, machine comes up and mounts the pool correctly to find the kernel, where previously zfsloader bailed out with an "unsupported pool feature" message

History

#1

Updated by Electric Monk almost 2 years ago

  • Status changed from New to Closed

git commit 6f8e6e5e0a44293205c7f187c667f9c9afa40795

commit  6f8e6e5e0a44293205c7f187c667f9c9afa40795
Author: Alex Wilson <alex.wilson@joyent.com>
Date:   2018-02-18T19:46:03.000Z

    9051 loader should ignore active multi_vdev_crash_dump feature on zpool
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF