Project

General

Profile

Bug #9064

ZFS test remove_mirror should wait for device removal to complete

Added by Pavel Zakharov over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Pavel Zakharov
Category:
zfs - Zettabyte File System
Start date:
2018-02-06
Due date:
% Done:

100%

Estimated time:
2.00 h
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

the remove_mirror test does a "zpool remove" on a regular vdev.
For regular (non-slog, non-cache) vdevs this operation is asynchronous and so we should wait on it to complete before trying to remove another device or re-adding the same device:

SUCCESS: default_setup_noexit /tmp/dsk1 mirror /tmp/dsk2 /tmp/dsk3
SUCCESS: zpool remove testpool /tmp/dsk1
SUCCESS: zpool remove testpool /tmp/dsk2 exited 1
invalid vdev specification use '-f' to override the following errors: /tmp/dsk1 is part of active pool 'testpool'
ERROR: zpool add testpool /tmp/dsk1 exited 1

Here's a test failure:
http://jenkins.open-zfs.org/blue/organizations/jenkins/openzfs%2Fopenzfs/detail/PR-518/2/pipeline

History

#1

Updated by Electric Monk over 2 years ago

  • % Done changed from 80 to 100
  • Status changed from New to Closed

git commit d8cfd210fd5a1952766872e066477af3df22c27c

commit  d8cfd210fd5a1952766872e066477af3df22c27c
Author: Prashanth Sreenivasa <pks@delphix.com>
Date:   2018-02-08T05:16:40.000Z

    9064 ZFS test remove_mirror should wait for device removal to complete
    Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
    Reviewed by: Matt Ahrens <mahrens@delphix.com>
    Reviewed by: John Kennedy <jwk404@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF