Project

General

Profile

Actions
Copy link

Bug #9132

closed

cw(1onbld) shouldn't shadow pure preprocessing

Added by Rich Lowe over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
tools - gate/build tools
Start date:
2018-02-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

When invoking Studio, cw(1onbld) doesn't invoke the compiler when it is being run as a shadow and purely for pre-processing.
For some reason, it does invoke GCC.

More recent GCC does not accept multiple pre-processing source files in combination with the -o option.
We should just not run either compiler when shadowing a preprocessing step.

Actions
Copy link
 #1

Updated by Electric Monk almost 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit aa9ef484c6f8ecee85dfefdb4970c50cfa2db302

commit  aa9ef484c6f8ecee85dfefdb4970c50cfa2db302
Author: John Levon <john.levon@joyent.com>
Date:   2018-10-04T00:34:40.000Z

    9128 cw(1onbld) should be able to run multiple shadows
    9129 file-locking tests shouldn't build multiple source files in one compiler invocation
    9130 DTrace tst.gcc.d isn't useful
    9132 cw(1onbld) shouldn't shadow pure preprocessing
    Portions contributed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF