Project

General

Profile

Actions
Copy link

Bug #9136

closed

libpicltree: this statement may fall through

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2018-02-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Issue from gcc 7 build:

    ../picltree.c: In function 'check_propsize':
    ../picltree.c:881:6: error: this statement may fall through [-Werror=implicit-fa
    llthrough=]
       if (op == PROP_WRITE) {
          ^
    ../picltree.c:887:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 33b51cd4c15f6c6cd095d25c6c263369cab880dc

commit  33b51cd4c15f6c6cd095d25c6c263369cab880dc
Author: Toomas Soome <tsoome@me.com>
Date:   2018-02-21T00:54:22.000Z

    9136 libpicltree: this statement may fall through
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF