Project

General

Profile

Actions
Copy link

Bug #9142

closed

libxcurses: comparison between pointer and zero character constant

Added by Toomas Soome over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2018-02-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Issue found by gcc 7 build:

    ../src/libc/xcurses/slk.c: In function 'slk_wset':
    ../src/libc/xcurses/slk.c:321:34: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
      for (wp = wcs, width = 0; label != '\0'; label += i, wp += cc._n) {
                                      ^~
    ../src/libc/xcurses/slk.c:321:28: note: did you mean to dereference the pointer?
      for (wp = wcs, width = 0; label != '\0'; label += i, wp += cc._n) {
                                ^
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit ea60f77b8bdb7a88d6143d8bd30ddebab992abee

commit  ea60f77b8bdb7a88d6143d8bd30ddebab992abee
Author: Toomas Soome <tsoome@me.com>
Date:   2018-04-01T21:48:00.000Z

    9142 libxcurses: comparison between pointer and zero character constant
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions
Copy link

Also available in: Atom PDF