Project

General

Profile

Bug #9146

libdtrace: this statement may fall through

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
DTrace
Start date:
2018-02-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

    ../common/dt_parser.c
    ../common/dt_parser.c: In function 'dt_node_decl':
    ../common/dt_parser.c:1467:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       xyerror(D_DECL_BADCLASS, "specified storage class not " 
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           "appropriate in D\n");
           ~~~~~~~~~~~~~~~~~~~~~
    ../common/dt_parser.c:1471:2: note: here
      case DT_DC_EXTERN: {
      ^~~~
    ../common/dt_parser.c: In function 'dt_cook_op2':
    ../common/dt_parser.c:3603:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       xyerror(D_OP_INCOMPAT,
       ^~~~~~~~~~~~~~~~~~~~~~
           "operands have incompatible types: \"%s\" %s \"%s\"\n",
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           dt_node_type_name(lp, n1, sizeof (n1)), opstr(op),
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           dt_node_type_name(rp, n2, sizeof (n2)));
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../common/dt_parser.c:3609:2: note: here
      case DT_TOK_ADD_EQ:
      ^~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk almost 2 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 86e879b181a8be14fca192bfe0030bec1310e4ca

commit  86e879b181a8be14fca192bfe0030bec1310e4ca
Author: Toomas Soome <tsoome@me.com>
Date:   2018-03-11T06:35:52.000Z

    9146 libdtrace: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Gordon Ross <gordon.w.ross@gmail.com>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Also available in: Atom PDF