Project

General

Profile

Actions

Bug #9149

closed

libbsm: comparison between pointer and zero character constant

Added by Toomas Soome almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2018-02-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Issue found by gcc 7 build:

    ../common/getauditflags.c:180:13: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
       if (flags == '\0') {
                 ^~
    ../common/getauditflags.c:180:7: note: did you mean to dereference the pointer?
       if (flags == '\0') {
           ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk almost 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a0be388cbf21b0e65786e7f1423e0212f9c6270d

commit  a0be388cbf21b0e65786e7f1423e0212f9c6270d
Author: Toomas Soome <tsoome@me.com>
Date:   2018-02-20T22:53:27.000Z

    9149 libbsm: comparison between pointer and zero character constant
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Albert Lee <trisk@forkgnu.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF