Project

General

Profile

Actions

Bug #9150

closed

libfcoe: this statement may fall through

Added by Toomas Soome almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2018-02-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Issue found by gcc 7 build:

    ../common/libfcoe.c: In function 'FCOE_GetPortList':
    ../common/libfcoe.c:771:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
         retry++;
         ~~~~~^~
    ../common/libfcoe.c:772:4: note: here
        default:
        ^~~~~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6cd9fed7b76d776476aa3e2d7d235423dcbf1e56

commit  6cd9fed7b76d776476aa3e2d7d235423dcbf1e56
Author: Toomas Soome <tsoome@me.com>
Date:   2018-05-14T13:23:40.000Z

    9150 libfcoe: this statement may fall through
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF