Project

General

Profile

Bug #9153

cfgadm_plugins: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2018-02-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

    ../common/cfga.c: In function 'cfga_private_func':
    ../common/cfga.c:1108:14: error: this statement may fall through [-Werror=implicit-fallthrough=]
        } else if (ptr == '\0') {
                  ^
    ../common/cfga.c:1114:3: note: here
       default:
       ^~~~~~~

    ../common/shp.c: In function 'cfga_private_func':
    ../common/shp.c:980:14: error: this statement may fall through [-Werror=implicit-fallthrough=]
        } else if (ptr == '\0') {
                  ^
    ../common/shp.c:986:3: note: here
       default:
       ^~~~~~~

    ../common/ap_seq.c: In function 'ap_seq_exec':
    ../common/ap_seq.c:330:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (!fastreboot_disabled &&
           ^
    ../common/ap_seq.c:338:3: note: here
       default:
       ^~~~~~~

    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 2411ecfcc7e4d3dc7fc3f78b9e50601e50a8a56c

commit  2411ecfcc7e4d3dc7fc3f78b9e50601e50a8a56c
Author: Toomas Soome <tsoome@me.com>
Date:   2018-02-23T15:33:23.000Z

    9153 cfgadm_plugins: this statement may fall through
    Reviewed by: Rob Johnston <rob.johnston@joyent.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF