Project

General

Profile

Bug #9160

libtecla: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2018-02-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 7 build:

    ../common/getline.c: In function '_gl_parse_config_line':
    ../common/getline.c:6483:14: error: this statement may fall through [-Werror=implicit-fallthrough=]
           action = argv[2];
           ~~~~~~~^~~~~~~~~
    ../common/getline.c:6484:5: note: here
         case 2:              /* Note the intentional fallthrough */
         ^~~~

    ../common/history.c:2720:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
           glh_step_stream(pstr);  /* Skip the backslash */
           ^~~~~~~~~~~~~~~~~~~~~
    ../common/history.c:2725:5: note: here
         default:
         ^~~~~~~

    ../common/expand.c:885:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
           pptr++;
           ~~~~^~
    ../common/expand.c:890:5: note: here
         default:
         ^~~~~~~

    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit cf421650297f304644a9fe84c51540de5823fe84

commit  cf421650297f304644a9fe84c51540de5823fe84
Author: Toomas Soome <tsoome@me.com>
Date:   2018-02-22T15:59:53.000Z

    9160 libtecla: this statement may fall through
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF